Refactor Architecture, OS, Vendor and TripletProfile into enums #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � src/main/java/com/gluonhq/substrate/ProjectConfiguration.java � src/main/java/com/gluonhq/substrate/SubstrateDispatcher.java � src/main/java/com/gluonhq/substrate/model/InternalProjectConfiguration.java � src/main/java/com/gluonhq/substrate/target/AbstractTargetConfiguration.java � src/main/java/com/gluonhq/substrate/target/DarwinTargetConfiguration.java � src/main/java/com/gluonhq/substrate/target/IosTargetConfiguration.java � src/main/java/com/gluonhq/substrate/target/LinuxTargetConfiguration.java � src/main/java/com/gluonhq/substrate/util/FileDeps.java
|
Issues
======
+ Solved 3
- Added 1
Complexity increasing per file
==============================
- src/main/java/com/gluonhq/substrate/target/TripletProfile.java 7
- src/main/java/com/gluonhq/substrate/target/Architecture.java 1
- src/main/java/com/gluonhq/substrate/target/Vendor.java 1
- src/main/java/com/gluonhq/substrate/target/OS.java 5
Complexity decreasing per file
==============================
+ src/main/java/com/gluonhq/substrate/model/Triplet.java -6
See the complete overview on Codacy |
eugener
commented
Dec 28, 2019
| @@ -0,0 +1,42 @@ | |||
| package com.gluonhq.substrate.target; | |||
|
|
|||
| import com.gluonhq.substrate.Constants; | |||
There was a problem hiding this comment.
johanvos
reviewed
Dec 29, 2019
| /** | ||
| * Predefined Profiles | ||
| */ | ||
| public enum TripletProfile { |
There was a problem hiding this comment.
This enum is actually the os-vendor combination of the triplet. I don't think we can map it like that. For example, Linux on AArch64 needs a separate profile (aarch64-linux-linux)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This for some useful methods on enums instead of using switch statements.